AXON-1839 Cancel API is failing to respond: #1549
Open
+70
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teg-atlassian
requested review from
BHulovatyi,
Blastoplex,
amarg-at,
bwieger-atlassian-com,
cabella-dot,
ccallcottstevens,
dchiew-atl,
jwang19-atlassian,
marcomura,
matt-lassian,
mattcolman,
om-ukr,
sdzh-atlassian and
sky-ocean-spirits
as code owners
bwieger-atlassian-com
previously approved these changes
Jan 30, 2026
marcomura
requested changes
Feb 4, 2026
Collaborator
marcomura
left a comment
marcomura
left a comment
There was a problem hiding this comment.
I don't believe this solution will work.
If we immediately abort the session on cancellation, and we don't wait for the cancellation to be confirmed by Rovo Dev, a subsequent prompt will result in 4xx as Rovo Dev thinks a chat is already in progress.
Contributor
Author
|
marcomura thanks for the catch. i have added code to address the case you mentioned
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Is This Change?
In this PR, we address a subtle issue in how session cancellation is handled.
Currently, when a user cancels a session with Rovo Dev IDE:
This approach has a drawback: the user’s cancellation request is not fully honored until Rovo Dev completes its side of the cancellation. In practice, this can leave the user waiting and create the impression that the UI is still “stuck” on the old session.
In this PR, when the user cancels a session:
How Has This Been Tested?
npm run test:unit -- src/rovo-dev/rovoDevChatProvider.test.test.ts
Basic checks:
npm run lintnpm run testAdvanced checks:
Recommendations:
Ask your organization admin to add you to Rovo Dev Standard.
More about code review errors